[v3] Filter out basever symbols on Solaris

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Wed Mar 6 11:08:00 GMT 2013


Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

> Andreas Schwab <schwab@suse.de> writes:
>
>> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>>
>>> diff --git a/libstdc++-v3/scripts/extract_symvers.in b/libstdc++-v3/scripts/extract_symvers.in
>>> --- a/libstdc++-v3/scripts/extract_symvers.in
>>> +++ b/libstdc++-v3/scripts/extract_symvers.in
>>> @@ -49,9 +49,12 @@ SunOS)
>>>    if readelf --help | grep -- --wide > /dev/null; then
>>>      readelf="$readelf --wide"
>>>    fi
>>> +  # Omit _DYNAMIC etc. for consistency with extract_symvers.pl, only
>>> +  # present on Solaris.
>>>    ${readelf} ${lib} |\
>>>    sed -e 's/ \[<other>: [A-Fa-f0-9]*\] //' -e '/\.dynsym/,/^$/p;d' |\
>>>    egrep -v ' (LOCAL|UND) ' |\
>>> +  egrep -v '(_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_end|_etext)$' |\
>>
>> Shouldn't the regexp also be anchored (with a space) at the beginning?
>
> This works indeed.  I was a bit worried if a space was guaranteed at
> that position, rather than general whitespace.  Consider the patch
> amended accordingly.

Any word on this patch?  Is has remained unreviewed for a week.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list