[C++] Fix __builtin_shuffle
Marc Glisse
marc.glisse@inria.fr
Thu Jun 27 21:58:00 GMT 2013
On Thu, 27 Jun 2013, Marc Glisse wrote:
> On Thu, 27 Jun 2013, Jakub Jelinek wrote:
>
>> On Thu, Jun 27, 2013 at 05:54:10PM +0200, Marc Glisse wrote:
>>> I don't really see why, as I am still calling c_build_vec_perm_expr
>>> in the same cases, just possibly not exactly with the same arguments
>>> (they don't go through build_non_dependent_expr, but Jason seemed to
>>> imply that it did not matter since we don't look too deep through
>>> the arguments).
>>
>> I guess you're right. If the c_* routine doesn't mind C++ specific trees
>> and just cares about their types and pt.c then instantiates it, then it is
>> fine.
>
> Even if both are fine, if you prefer the long version (safer, or more uniform
> with the rest), please say so, I don't mind.
I committed the short version, since that's the one I currently had in my
tree (and I had tested it). We can always change it later.
Thanks to you both for the comments,
--
Marc Glisse
More information about the Gcc-patches
mailing list