[PATCH] Cilk Plus Array Notation for C++

Iyer, Balaji V balaji.v.iyer@intel.com
Fri Jun 21 16:59:00 GMT 2013



> -----Original Message-----
> From: Richard Henderson [mailto:rth@redhat.com]
> Sent: Friday, June 21, 2013 12:11 PM
> To: Iyer, Balaji V
> Cc: Aldy Hernandez; gcc-patches@gcc.gnu.org; Jason Merrill
> (jason@redhat.com)
> Subject: Re: [PATCH] Cilk Plus Array Notation for C++
> 
> On 06/20/2013 04:39 PM, Iyer, Balaji V wrote:
> > I couldn't put them into 1 structure, so I made 2 structures holding
> > the following information: array notation triplet information and
> > array notation expansion loop's information. It is fixed in the patch attached.
> 
> Excellent, thanks.  One thing that seems to be missed in this conversion is that
> .count_down is never set, only read.  Mistake in +cilkplus_extract_an_triplets?

Count down came from an initial implementation were if the stride was negative, I set that bool to true and then we count down. But, the way it stands now, I can remove the count down field. I can remove it.

After I remove that field, will it be OK for trunk?

Thanks,

Balaji V. Iyer.
> 
> Otherwise this is looking good.
> 
> 
> r~



More information about the Gcc-patches mailing list