[PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self

Jakub Jelinek jakub@redhat.com
Wed Jun 19 17:47:00 GMT 2013


On Wed, Jun 19, 2013 at 05:29:42PM +0200, Matthias Klose wrote:
> well, I did fix this assumption last year in gcc.c, then lets fix it in other
> places too, just adding a mode parameter to the public find_a_file function.
> Testing the attached patch.

Ok, provided you:
1) write proper ChangeLog
2) adjust the gcc-ar.c change (because it won't apply cleanly now that
   I've committed the other gcc-ar.c fix
3) 
> --- file-find.h	(revision 200203)
> +++ file-find.h	(working copy)
> @@ -38,7 +38,7 @@
>  };
>  
>  extern void find_file_set_debug (bool);
> -extern char *find_a_file (struct path_prefix *, const char *);
> +extern char *find_a_file (struct path_prefix *, const char *, int mode);

Remove " mode" above, none of the arguments have names, so adding it
is both inconsistent and useless.

4)
>    if (ld_file_name == 0)
> -    ld_file_name = find_a_file (&path, full_ld_suffixes[selected_linker]);
> +    ld_file_name = find_a_file (&path, full_ld_suffixes[selected_linker], X_OK);

This line looks too long now.

	Jakub



More information about the Gcc-patches mailing list