GCC does not support *mmintrin.h with function specific opts

Sriraman Tallam tmsriram@google.com
Tue Jun 18 22:46:00 GMT 2013


On Mon, Jun 17, 2013 at 10:49 AM, Sriraman Tallam <tmsriram@google.com> wrote:
> On Fri, Jun 14, 2013 at 11:08 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>> On Fri, Jun 14, 2013 at 1:43 AM, Richard Biener
>> <richard.guenther@gmail.com> wrote:
>>> On Fri, Jun 14, 2013 at 4:52 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>>>> On Thu, Jun 13, 2013 at 12:40 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
>>>>>>       * tree-inline.c (expand_call_inline): Allow the error to be flagged
>>>>>>       in early inline pass.
>>>>>>       * ipa-inline.c (inline_always_inline_functions): Pretend always_inline
>>>>>>       functions are inlined during failures to flag an error.
>>>>>>       * gcc.target/i386/inline_error.c: New test.
>>>>
>>>>> This patch is OK if it passes testing.
>>>>
>>>> Two tests gcc.c-torture/compile/pr43791.c and pr44043.c are failing
>>>> because of always_inline functions being present that cannot be
>>>> inlined and the compiler is now generating error messages. I will fix
>>>> them and resend the patch.
>>>
>>> Quick look - pr43791.c is not expected to work at -O0, so skip -O0
>>> for example by guarding the whole thing with #if __OPTIMIZED__ > 0.
>>> Similar for pr44043.c.
>>
>> Seems like __OPTIMIZED__ is not defined in my config, dont know why. I
>> see other tests checking for __OPTIMIZED.
>>
>> I fixed these two tests by adding a dg-prune-output at the end. Is
>> that reasonable? I have attached the patch with all tests passing now.
>
> I have attached the latest patch with a small error in the previous
> patch fixed. I will submit this patch if there are no objections.

I have committed this patch.

Thanks
Sri

>
> Thanks
> Sri
>
>>
>> Thanks
>> Sri
>>
>>>
>>> That we didn't error at -O0 before is a bug.  Eventually I was suggesting
>>> to error if we end up outputting the body of an always_inline function,
>>> that is, any uses remain (including indirect calls or address-takens which
>>> is where we do not error right now).
>>>
>>> Richard.
>>>
>>>> Thanks
>>>> Sri
>>>>
>>>>> Thanks for your patience!
>>>>
>>>>
>>>>
>>>>>
>>>>> Honza



More information about the Gcc-patches mailing list