[PATCH, committed] PR 57589: Fix logic error in driver-rs6000.c

Michael Meissner meissner@linux.vnet.ibm.com
Tue Jun 11 23:43:00 GMT 2013


On Wed, Jun 12, 2013 at 01:34:59AM +0200, Jakub Jelinek wrote:
> On Tue, Jun 11, 2013 at 07:25:36PM -0400, Michael Meissner wrote:
> > I committed the following patch as obvious, after making sure it builds and has
> > no regressions.  I was looking at driver-rs6000.c today, and I noticed that it
> > was returning an address to an auto buffer for processing -mcpu=native.
> 
> Does it?  If I understand it right, the string itself isn't read into buf
> (after all, what would translate the pointers in buf to point into other
> parts of buf), /proc/self/auxv just contains the pairs of AT_* and the
> corresponding values, for AT_PLATFORM that value is a char * pointing
> somewhere into stack memory.

Ah, you are correct.  I misread the code, thinking it was returning a string,
and not a pointer to the string in memory.

I'll remove it tomorrow, and put in a comment for the next person.  Sigh....

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797



More information about the Gcc-patches mailing list