[patch] Fix parsing bug in validate_patches.py

Brooks Moses bmoses@google.com
Wed Jun 5 18:34:00 GMT 2013


On 06/04/2013 03:57 PM, Diego Novillo wrote:
> OK with this predicate factored into a predicate function (maybe
> SummaryLineHasAttributes?)

Thanks!  Once I dove into that, I ended up doing a bit more refactoring; 
it really makes sense to pull the whole line-splitting into a separate 
function along with this.

Thus, I'm attaching an updated patch file that reflects that, along with 
a couple of other trivial changes I added since submitting the initial 
patch.

I've tested the adjusted line-stripping parts of the refactored code by 
adding and removing spaces in lines in my xfails file and confirming 
that things are still correctly matched.

Is this refactoring also OK to commit?

Thanks,
- Brooks


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2013-06-05_validate-patches.diff
Type: text/x-patch
Size: 3651 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20130605/4c279614/attachment.bin>


More information about the Gcc-patches mailing list