[Committed] Introduce beginnings of gcc::pass_manager class (was Re: [PATCH 01/11] Introduce beginnings of a pipeline class.)

David Malcolm dmalcolm@redhat.com
Tue Jul 30 19:02:00 GMT 2013


On Mon, 2013-07-29 at 13:56 -0600, Jeff Law wrote:
> On 07/26/2013 09:04 AM, David Malcolm wrote:
[...snip quote of ChangeLog...]
> So as has been discussed elsewhere I'd like to see pipeline changed to 
> pass_manager.
> 
> WRT references.  Not being a C++ guy, I'd always mentally equated 
> references with pointers.   I've done a little reading and it seems that 
> references actually convey more information, which I'm generally a fan 
> of -- with the caveat that they're pointers that act more like values, 
> which might get confusing.
> 
> At least in the immediate term, I think we should stick with pointers 
> until we have a clearer sense of whether or not we want to be using 
> references in this way.  I doubt it's terribly important, but the 
> non-nullness ought to be expressable via an attribute.
> 
> With the pipeline->pass_manager change and using pointers instead of 
> references on the return type, this patch is fine.  Pre-approved with 
> those changes.

Thanks.  I've committed the attached to trunk as r201351, having done
the following:
* rebased against trunk
* renamed class pipeline and file pipeline.h to class pass_manager and
file pass_manager.h
* replaced uses of references with pointers
* context.c (context::context): Fixed missing space in pass_manager
constructor invocation noted by Martin Jambor in
http://gcc.gnu.org/ml/gcc-patches/2013-07/msg01155.html
* successfully bootstrapped the new patch on x86_64-unknown-linux-gnu
and reran the testsuite: all testcases showed the same results as an
unpatched build (relative to r201317).
* verified that the patch builds on an updated svn checkout.

Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Introduce-beginnings-of-a-pass_manager-class.patch
Type: text/x-patch
Size: 29026 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20130730/d0c1ab69/attachment.bin>


More information about the Gcc-patches mailing list