[testsuite, android] Disabling thread_local4.C and thread_local4g.C for Android.

Alexander Ivchenko aivchenk@gmail.com
Fri Jul 12 13:21:00 GMT 2013


*ping*

Thank you,
Alexander

2013/6/20 Alexander Ivchenko <aivchenk@gmail.com>:
> Hi,
>
> for Android:
>
> FAIL: g++.dg/tls/thread_local4.C -std=gnu++11 (test for excess errors)
> Excess errors:
> <>/gcc/testsuite/g++.dg/tls/thread_local4.C:31:26: error:
> 'pthread_testcancel' was not declared in this scope
> <>/gcc/testsuite/g++.dg/tls/thread_local4.C:40:24: error:
> 'pthread_cancel' was not declared in this scope
>
> the same for thread_local4g.C.
>
> from http://www.kandroid.org/ndk/docs/system/libc/OVERVIEW.html
> "pthread_cancel() will not be supported in Bionic, because doing this
> would involve making the C library significantly bigger for very
> little benefit.
> <...>"
>
> The following patch switches those tests off for Android.
>
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index b8073d1..d217e4d 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-06-19  Alexander Ivchenko  <alexander.ivchenko@intel.com>
> +
> +       * g++.dg/tls/thread_local4.C: Disable test for Android.
> +       * g++.dg/tls/thread_local4g.C: Ditto.
> +
>  2013-06-11  Tobias Burnus  <burnus@net-b.de>
>
>         PR fortran/57508
> diff --git a/gcc/testsuite/g++.dg/tls/thread_local4.C
> b/gcc/testsuite/g++.dg/tls/thread_local4.C
> index acf1cae..cc1a35a 100644
> --- a/gcc/testsuite/g++.dg/tls/thread_local4.C
> +++ b/gcc/testsuite/g++.dg/tls/thread_local4.C
> @@ -1,6 +1,7 @@
>  // Test for cleanups with pthread_cancel.
>
> -// { dg-do run }
> +// There is no support of pthread_cancel in Android.
> +// { dg-do run { target { ! *-*-android* } } }
>  // { dg-require-effective-target c++11 }
>  // { dg-require-effective-target tls_runtime }
>  // { dg-require-effective-target pthread }
> diff --git a/gcc/testsuite/g++.dg/tls/thread_local4g.C
> b/gcc/testsuite/g++.dg/tls/thread_local4g.C
> index f5bc3ff..756c6a2 100644
> --- a/gcc/testsuite/g++.dg/tls/thread_local4g.C
> +++ b/gcc/testsuite/g++.dg/tls/thread_local4g.C
> @@ -1,6 +1,7 @@
>  // Test for cleanups with pthread_cancel.
>
> -// { dg-do run }
> +// There is no support of pthread_cancel in Android.
> +// { dg-do run { target { ! *-*-android* } } }
>  // { dg-require-effective-target c++11 }
>  // { dg-require-effective-target tls_runtime }
>  // { dg-require-effective-target pthread }
>
>
> is it ok for trunk?
>
>
> --Alexander



More information about the Gcc-patches mailing list