[PR libmudflap/53359] don't register symbols not emitted

Alexandre Oliva aoliva@redhat.com
Wed Jan 16 13:17:00 GMT 2013


On Jan 16, 2013, Jan Hubicka <hubicka@ucw.cz> wrote:

> 2) has the obvious advantage that unused vars are not going to be output just
> for sake of checking code.  For 2) the symtab_get_node test seems resonable to
> me.

That's what I first implemented, and I still firmly believe
symtab_get_node is the correct test.  TREE_ASM_WRITTEN doesn't carry the
same information as far as external objects are concerned, so we ended
up failing to register them when I tried it, and that caused regressions
in the testsuite, with tests that were designed to catch precisely this
sort of error.

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer



More information about the Gcc-patches mailing list