[PATCH] Fix PR56344

Joseph S. Myers joseph@codesourcery.com
Tue Feb 26 23:17:00 GMT 2013


On Tue, 26 Feb 2013, Marek Polacek wrote:

> +	      /* We don't allow passing huge (> 2^30 B) arguments
> +	         by value.  It would cause an overflow later on.  */
> +	      if (adjusted_args_size.constant >= (1 << 30))
> +	        {
> +	          error ("passing too large argument on stack");
> +		  continue;

This should be sorry () not error (), as a compiler limitation rather than 
a defect in the user's program.  (And is input_location set to something 
useful here so the diagnostic points to the argument in question rather 
than e.g. to the end of the function containing the problem call?)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list