[PATCH] Check headers in verify_loop_structure

Toon Moene toon@moene.org
Fri Feb 8 11:39:00 GMT 2013


On 02/08/2013 12:20 PM, Richard Biener wrote:

> On Thu, 7 Feb 2013, Marek Polacek wrote:
>
>> On Thu, Feb 07, 2013 at 02:56:48PM +0100, Richard Biener wrote:
>>>> +  /* Check the headers.  */
>>>> +  FOR_EACH_BB (bb)
>>>> +    {
>>>> +      /* Skip BBs in the root tree.  */
>>>> +      if (bb->loop_father == current_loops->tree_root)
>>>> +	continue;
>>>
>>> You shouldn't need this ... it will miss missing toplevel loops
>>
>> Done.
>>
>>>> +      if (bb_loop_header_p (bb))
>>>> +	if (bb->loop_father->header != bb)
>>>
>>>    &&  bb->loop_father->header != bb)
>>
>> Fixed.  Regtested/bootstrapped on x86_64 again (with tailc fix:
>> http://gcc.gnu.org/ml/gcc-patches/2013-02/msg00310.html), ok now?
>
> Ok.  Let's watch for fallout...
>
> Thanks,
> Richard.

Maybe here:

http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg00835.html

?

-- 
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
At home: http://moene.org/~toon/; weather: http://moene.org/~hirlam/
Progress of GNU Fortran: http://gcc.gnu.org/wiki/GFortran#news



More information about the Gcc-patches mailing list