libgo patch committed: Fixes for select based pollster

Ian Lance Taylor iant@google.com
Thu Feb 7 17:04:00 GMT 2013


On Thu, Feb 7, 2013 at 8:51 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> Ian Lance Taylor <iant@google.com> writes:
>
>> On Solaris the libgo networking library uses select.  This patch
>> implements some fixes for that code.  The Close method is changed to
>> actually do something; this is mainly for testing purposes.  More
>> importantly, when a socket is closed, the select needs to be restarted
>> so that the callers see the close.  Bootstrapped and ran Go testsuite on
>> x86_64-unknown-linux-gnu.  Committed to mainline.
>>
>
> Thanks, this got net to almost passing on Solaris: the only remaining
> failure is
>
> pollServer WaitFD: pollster closed
> --- FAIL: TestMulticastListener (0.00 seconds)
> multicast_posix_test.go:70:     "224.0.0.254:12345" not found in RIB
> multicast_posix_test.go:75:     "224.0.0.254:12345" not found in RIB
> multicast_posix_test.go:70:     "224.0.0.254:12345" not found in RIB
> multicast_posix_test.go:75:     "224.0.0.254:12345" not found in RIB
> Select unexpected fd=13 for write
> FAIL
> FAIL: net
>
> which is no wonder since Solaris still uses interface_stub.go.  I've
> checked what it takes to implement those interfaces, but it's quite an
> effort, so for the moment we should just skip the test.
>
> The following patch does this and allows the net test to pass.

Thanks.  Committed.

Ian



More information about the Gcc-patches mailing list