[RFC] [PATCH, i386] Adjust unroll factor for bdver3 and bdver4
Uros Bizjak
ubizjak@gmail.com
Wed Dec 11 10:41:00 GMT 2013
On Wed, Dec 11, 2013 at 11:27 AM, Gopalasubramanian, Ganesh
<Ganesh.Gopalasubramanian@amd.com> wrote:
> Accommodated the changes that you mentioned.
> Completed the bootstrap testing too.
Please provide updated ChangeLog.
The function comment is missing. Maybe you should also describe magic
number 32 here?
+static unsigned
+ix86_loop_unroll_adjust (unsigned nunroll, struct loop *loop)
+ if (!ix86_tune_features [X86_TUNE_ADJUST_UNROLL])
+ return nunroll;
Please add
#define TARGET_ADJUST_UNROLL \
ix86_tune_features[X86_TUNE_ADJUST_UNROLL]
to i386.h and use definition here.
Otherwise, the patch looks OK.
BTW: Please avoid top-posting, see e.g. [1] for reasons...
[1] http://gcc.gnu.org/ml/gcc/2008-08/msg00133.html
Uros.
More information about the Gcc-patches
mailing list