Remove regexp and expected output from gtest pass/fail line
Jakub Jelinek
jakub@redhat.com
Sun Dec 8 21:16:00 GMT 2013
On Sun, Dec 08, 2013 at 07:18:37PM +0000, Richard Sandiford wrote:
> gcc/testsuite/
> * lib/asan-dg.exp (asan-gtest): Remove actual and expected output
> from the pass/fail line and add it to the log instead.
Looks ok to me, except the ChangeLog, all I'm seeing is that you are
removing expected output from the pass/fail line, not the actual output.
> --- gcc/testsuite/lib/asan-dg.exp 2013-12-04 10:47:41.499044571 +0000
> +++ gcc/testsuite/lib/asan-dg.exp 2013-12-08 19:18:01.840876860 +0000
> @@ -288,9 +288,10 @@ proc asan-gtest { args } {
> if { "$status" == "fail" } {
> pass "$testname execution test"
> if { ![regexp $regexpr ${output}] } {
> - fail "$testname output pattern test, should match $regexpr"
> + fail "$testname output pattern test"
> + send_log "Output should match: $regexpr\n"
> } else {
> - pass "$testname output pattern test, $regexpr"
> + pass "$testname output pattern test"
> }
> } elseif { "$status" == "pass" } {
> fail "$testname execution test"
Jakub
More information about the Gcc-patches
mailing list