libsanitizer merge from upstream r196090
Marek Polacek
polacek@redhat.com
Mon Dec 2 14:57:00 GMT 2013
On Mon, Dec 02, 2013 at 03:47:18PM +0100, Jakub Jelinek wrote:
> On Mon, Dec 02, 2013 at 03:41:18PM +0100, Marek Polacek wrote:
> > On Mon, Dec 02, 2013 at 02:41:05PM +0100, Marek Polacek wrote:
> > > On Mon, Dec 02, 2013 at 03:52:09PM +0400, Konstantin Serebryany wrote:
> > > > This change breaks one ubsan test:
> > > > make check -C gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} ubsan.exp'
> > > > FAIL: c-c++-common/ubsan/vla-1.c -O0 execution test
> > > > I am asking gcc-ubsan maintainers to help me decipher dejagnu
> > > > diagnostics and fix the test failure.
> > >
> > > Ok, reproduced. I'll look into it.
> >
> > Well, this should help. The problem is that the testcase, when run,
> > SIGSEGVed, but since we're doing Ugly Things (VLAs with negative
> > size), it of course _can_ segfault, we're just relying that it
> > doesn't.
>
> Suppossedly it might be better to split the main from the test into multiple
> functions, with __attribute__((noinline)) and just one invalid VLA in each.
Okay, I'll do this separately.
So, Kostya, I guess just do the merge and I'll take care of that ubsan
fail.
Marek
More information about the Gcc-patches
mailing list