[patch] Fix PR middle-end/59138

Bernd Edlinger bernd.edlinger@hotmail.de
Sun Dec 1 09:20:00 GMT 2013


Hi,

On Fri, 29 Nov 2013 12:28:15, Eric Botcazou wrote:
>
>> I think I see a small flaw in that patch:
>> + /* Make sure not to write past the end of the struct. */
>> + store_bit_field (dest,
>> + adj_bytelen * BITS_PER_UNIT, bytepos * BITS_PER_UNIT,
>> + bytepos * BITS_PER_UNIT, ssize * BITS_PER_UNIT,
>> + VOIDmode, tmps[i]);
>> the parameter BITREGION_END is wrong.
>> it should be:
>> ssize * BITS_PER_UNIT - 1
>
> This won't change anything since you cannot access one bit without accessing
> its unit but yes, it's more correct. Feel free to change it on both branches.
>
> --
> Eric Botcazou

Ok, committed as obvious, in both branches, after regression-testing.

Thanks
Bernd. 		 	   		  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-emit-group-store.diff
Type: application/octet-stream
Size: 889 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20131201/0bf65aeb/attachment.obj>


More information about the Gcc-patches mailing list