[Patch] Rewrite regex matchers

Paolo Carlini paolo.carlini@oracle.com
Fri Aug 30 13:32:00 GMT 2013


Hi,

On 08/30/2013 02:05 PM, Tim Shen wrote:
> +      const _TraitsT&                    _M_traits;
> +      _FlagT                             _M_flags;
> +      bool                               _M_is_non_matching;
> +      std::set<_CharT>                   _M_char_set;
> +      std::set<pair<_StringT, _StringT>> _M_range_set;
> +      _CharClassT                        _M_class_set;
another, very general comment: now that nothing is decided ABI-wise for 
these features, let's pay attention to the layouts, let's make sure that 
the data members are ordered in the best way to minimize the size. For 
example, when I see a bool sandwiched between big objects something 
seems at least weird... Let's make measurements and optimize for 64-bit 
but let's double check on 32-bit too.

Paolo.



More information about the Gcc-patches mailing list