[PATCH] Combine location with block using block_locations

Tom Tromey tromey@redhat.com
Thu Sep 13 16:49:00 GMT 2012


>>>>> "Dehao" == Dehao Chen <dehao@google.com> writes:

Dehao> + static htab_t location_adhoc_data_htab;
Dehao> + static source_location curr_adhoc_loc;
Dehao> + static struct location_adhoc_data *location_adhoc_data;
Dehao> + static unsigned int allocated_location_adhoc_data;

libcpp was written to allow multiple preprocessor objects to be created
and used in one process.  I think introducing globals like this breaks
this part of the design.  It seems to me they should instead be fields
of cpp_reader or line_maps.

Tom



More information about the Gcc-patches mailing list