shrink-wrapping duplicates BBs across partitions.

Christian Bruel christian.bruel@st.com
Thu Sep 13 07:02:00 GMT 2012



>> 1) fixes the problem, so 5 and 4 are now in the same partition. The fix
>> is quite trivial, as with attached.
> 
> That looks obviously correct to me. I can't approve it, but I'd have
> committed it as obvious.
> 

Thanks, I'll  make the formal request, after checking forthe unexpected
side effects

> 
> 
>> I don't think 3) is necessary.
> 
> I think it *is* necessary. From cfg-flags.def:
> /* Edge crosses between hot and cold sections, when we do partitioning.
>    This flag is only used for the RTL CFG.  */
> DEF_EDGE_FLAG(CROSSING, 11)
> 
> Edge 5-4 is a crossing edge, so EDGE_CROSSING should be set.

OK, I'll try to investigate this while it's hot and before the symptom
disappears after committing the bb->count... that would still be latent
somewhere.

thanks

Christian


> 
> Ciao!
> Steven
> 



More information about the Gcc-patches mailing list