[C++ Patch] Remove uses of ATTRIBUTE_UNUSED in the function parameters

Paolo Carlini paolo.carlini@oracle.com
Tue Sep 11 16:17:00 GMT 2012


On 09/11/2012 05:37 PM, Jakub Jelinek wrote:
> On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:
>> PS: slightly interesting, in a couple of cases -
>> write_unnamed_type_name, wrap_cleanups_r - the parameters were
>> actually used.
> Just a general comment, often an argument is only conditionally used,
> e.g. depending on some preprocessor macro (e.g. target hook).  In that
> case unnamed parameter is not an option, but dropping ATTRIBUTE_UNUSED is
> not desirable either.
Of course. As far as I can see, that isn't the case for the C++ 
front-end uses, but hey, if you spot something which *may* be less than 
straightforward in my patch, please let me know asap!

Paolo.



More information about the Gcc-patches mailing list