[PATCH] Merging Cilk Plus into Trunk (Patch 1 of approximately 22)

[Iyer, Balaji V]

>-----Original Message-----
>From: Joseph Myers [mailto:joseph@codesourcery.com]
>Sent: Monday, September 10, 2012 7:23 AM
>To: Iyer, Balaji V
>Cc: gcc-patches@gcc.gnu.org; Aldy Hernandez (aldyh@redhat.com); Jeff Law;
>rth@redhat.com
>Subject: RE: [PATCH] Merging Cilk Plus into Trunk (Patch 1 of approximately 22)
>
>On Sun, 9 Sep 2012, Iyer, Balaji V wrote:
>
>> 	Here is an updated patch. I think I have fixed all the changes you
>> and others have mentioned. Please let me know if everything looks OK.
>> Thanks again for doing the review!
>
>Has the user documentation for this feature been posted?  For patch review we
>really need a self-contained submission that for any feature implemented
>includes not just the implementation but the testcases and the documentation.  I
>think the testsuite patch also needs reworking to make it easy to add support for
>new architectures.

I think you had some changes for the test cases and I am currently working on it. 

>
>I think you need to revisit your split into 22 patches and arrange things based
>primarily on features.  If the changes for a feature are so big they can't be posted
>in one message, you should still always post all the patches for that feature
>together (implementation, documentation,
>testcases) - even if not all parts have changed in a particular revision.

So, I assume it is OK for me to include testsuites with the code-changes? I included them separately because I remember someone in the mailing list saying the patch size must be small and one logical way is to put test cases separately from the code-changes.

>
>--
>Joseph S. Myers
>joseph@codesourcery.com