Fold VEC_PERM_EXPR a little more

Marc Glisse marc.glisse@inria.fr
Mon Sep 3 09:15:00 GMT 2012


On Sun, 2 Sep 2012, Hans-Peter Nilsson wrote:

> On Sat, 1 Sep 2012, Marc Glisse wrote:
>> gcc/
>> 	* fold-const.c (fold_ternary_loc): Constant-propagate after
>> 	removing dead operands.
>>
>> gcc/testsuite/
>> 	* gcc.dg/fold-perm.c: Improve test.
>
> (adding a line and a parameter to the function containing the test-code)
>
> JFTR: generally speaking, editing existing tests is frowned
> upon.  Adding a new separate test is almost always better.
> Not sure there's reason for an exception this time, but I see
> you're the author of the original test and it's < 2 weeks since
> it was added.

Thanks for the comment. I am not sure there is much I can add to that. I 
know it is better to avoid modifying existing tests. And the fact that I 
am completing my patch from 2 weeks ago made me think it was ok this time. 
I'll break it up into fold-perm-2.c if the reviewer asks for it.

-- 
Marc Glisse



More information about the Gcc-patches mailing list