[PATCH 3/3] [asan] Instrument built-in memory access function calls
Hans-Peter Nilsson
hp@bitrange.com
Mon Oct 29 15:15:00 GMT 2012
On Wed, 24 Oct 2012, Dodji Seketeli wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> > On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote:
> > > * asan.c (insert_if_then_before_iter)
> > > (instrument_mem_region_access)
> > > (maybe_instrument_builtin_call, maybe_instrument_call): New static
> >
> > Why not just write it:
> > * asan.c (insert_if_then_before_iter, instrument_mem_region_access,
> > maybe_instrument_builtin_call, maybe_instrument_call): New static
> > ?
>
> It's emacs that formats it like that automatically. I am not sure how
> to teach him otherwise. I have fixed this as you want by doing it "by
> hand".
JFTR, the emacs-formatted-version *is* the correct one, at least
when going by the GNU coding standard. Maybe something about
being eager to balance parentheses as early as possible. :)
But, I'll keep formatting it like that myself until someone
updates the GCC coding standard. Hint, like.
brgds, H-P
More information about the Gcc-patches
mailing list