[PATCH] Adjust target for vect/pr48765.c

Peter Bergner bergner@vnet.ibm.com
Fri Oct 12 19:42:00 GMT 2012


On Fri, 2012-10-12 at 10:17 -0700, Janis Johnson wrote:
> No, the test should not add -m64, and -mcpu=power6 might conflict
> with multilib options.  I proposed a different fix for this test in
> <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01320.html> and then
> didn't follow up on it.
> 
> I've copied Ira who added the test to see what she thinks of my
> proposed change, and David as the Power maintainer.

Just my $0.02 worth Janis, but I liked your patch, since it attempts
to test the test case with the options that exposed the bug in the
first place (ie, -mcpu=power6), but plays nicely with people who want
to explicitly set -mcpu= to something else.  Your other suggestion
would mean the only time the test case is tested with the options that
made it fail originally would be when someone does a --with-cpu=power6
build and that isn't something we do now that power7 has been released
for a while now.

Peter





More information about the Gcc-patches mailing list