[Patch,testsuite] ad PR52641: More fixes for not-so-common targets

[Hans-Peter Nilsson]

On Mon, 26 Nov 2012, Georg-Johann Lay wrote:
> Hans-Peter Nilsson wrote:
> > On Fri, 23 Nov 2012, Georg-Johann Lay wrote:
> >> Here are some more fixes for 16-bit int and similar.
> >
> >> 	* gcc.c-torture/execute/20120919-1.x: New file (int32plus).
> >
> > No, you should be able to use dg-directives in the main file these days.
> > (The .x files are obsolete since a few years, IIRC.)
>
> Would you be more specific?

You seem to have understood what I meant, so I guess not needed. :)

> AFAIK this works only with dg.

I had another look.  I thought Mark Mitchells overhaul in
2003 adjusted *all* gcc/testsuite subdirectories; I grepped
gcc.c-torture/execute/* and gcc.c-torture/compile/* for "dg-",
lots of apparently-working examples.

But that's wrong; observe the differences between
gcc.c-torture/execute/execute.exp and
gcc.c-torture/compile/compile.exp; they should differ only in
the dg-do-what-default, but the whole dg- thing is missing in
gcc.c-torture/execute/execute.exp.  I haven't dug into the ml
archives for the reason, maybe there were problems and not
enough time to solve them.  At least according to svn it doesn't
seem to be a reverted change.

> After removing the x file and adding
>
> /* { dg-do run } */
> /* { dg-require-effective-target int32plus } */
>
> to the test it is still executed.

Yeah...  If it had been a new test, I would have suggested to
put it in gcc.dg/torture instead, the new preferred home for
executed torture-tests.  So unless you feel like completing
Mark's dg- makeover for gcc.c-torture/execute you'll have to go
with your .x file.  Sorry for putting you on the wrong track,
but thanks for getting light on the issue.

Mike, other testsuite maintainers; heads-up: there are several
dg- directives in files in gcc.c-torture/execute.  That's just
misleading, since they have no effect.  (I just verified that,
testing a few examples.)

brgds, H-P