libstdc++ PATCH to add abi tag to complex::real/imag

Jonathan Wakely jwakely.gcc@gmail.com
Sun Nov 11 11:56:00 GMT 2012


On 11 November 2012 02:27, Jason Merrill wrote:
>
> Is this patch OK for trunk?  Does someone on the library team want to look
> at the other cases?

The patch looks good to me. Thanks for implementing the attribute.

I'll start looking at some of the other cases.

For std::list I assume we want the attribute on the type itself, not
just member functions, since its size changes.

For vector::data() we should be able to make the attribute conditional
on is_same<_Tp*,allocator_type::pointer> so it doesn't change mangling
unless necessary.

As well as the existing incompatibilities, I need to add a new virtual
function to support returning future_status::deferred from
std::future::wait_{for,until}.  Is it appropriate to use the same
"cxx11" tag for that too, even though the existing implementation is
also "cxx11" because the type wasn't in C++98?   Or do we want to use
a different tag, such as "cxx11v2" or just "v2"?



More information about the Gcc-patches mailing list