[C++ Patch] PR 29185

Gabriel Dos Reis gdr@integrable-solutions.net
Wed May 23 14:13:00 GMT 2012


On Wed, May 23, 2012 at 5:24 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> On 05/23/2012 04:54 AM, Gabriel Dos Reis wrote:
>>
>> On Tue, May 22, 2012 at 8:25 PM, Paolo Carlini<paolo.carlini@oracle.com>
>>  wrote:
>>>
>>> Hi,
>>>
>>> some years ago Martin lamented that we weren't consistently warning about
>>> deleting member arrays vs arrays. A fix seems simple and passes bootstrap
>>> and testing on x86_64-linux. Note I have to change D to E because
>>> dump_decl
>>> cannot cope with COMPONENT_REFs.
>>
>> dump_decl can't handle COMPONENT_REF because it is an expression.
>> I suspect you want to look at the operand 1 instead of changing D to E.
>
> Gaby, at some point I did that, but then it didn't work with the third case.
> In general, I understand that this is an expression and I would rather rely
> on dump_expr, which has logic to unwrap all the various possibilities. This,
> indeed, as long as we print expressions at all. For the time being, If you
> like I can test DECL_P and use either D or E. Just let me know.

With Jason's suggestion of testing for just any expression of array type,
it makes sense to change D to E.

-- Gaby



More information about the Gcc-patches mailing list