[PATCH] PR preprocessor/7263 - Avoid pedantic warnings on system headers macro tokens
Jason Merrill
jason@redhat.com
Fri May 4 18:29:00 GMT 2012
On 05/04/2012 12:32 PM, Dodji Seketeli wrote:
> Jason Merrill<jason@redhat.com> writes:
>
>>> + decl_specs->locations[cpdw_builtin_type_spec] = location;
>>> if (!decl_specs->type)
>>> {
>>> decl_specs->type = type_spec;
>>> decl_specs->type_definition_p = false;
>>> - decl_specs->type_location = location;
>>> + decl_specs->locations[cpdw_type_spec] = location;
>>
>> Why do we need cpdw_builtin_type_spec?
>
> To unify the way we access locations for the specifiers. Otherwise, it
> looks awkward to have a lone decl_specs->type_location for the type
> specifier, whereas the other specifiers have their locations in
> decl_specs->locations. But if you don't like that, I'll just revert it.
No, I agree that cpdw_type_spec makes sense. I just don't see why we
need the _builtin_ variant.
Jason
More information about the Gcc-patches
mailing list