PR c/51712 -Wtype-limits should not trigger for types of implementation-defined signedness

Joseph S. Myers joseph@codesourcery.com
Tue May 1 13:46:00 GMT 2012


On Tue, 1 May 2012, Manuel López-Ibáñez wrote:

> +static tree expr_original_type (tree expr)

That should be

static tree
expr_original_type (tree expr)

with a comment explaining the semantics of the function.

> +{
> +  STRIP_NOPS (expr);

Are you sure you want STRIP_NOPS rather than STRIP_SIGN_NOPS here?  If so, 
could you ensure there are comments explaining why removing sign changes 
is safe in this context?

-- 
Joseph S. Myers
joseph@codesourcery.com


More information about the Gcc-patches mailing list