PATCH [1/n] addr32: Properly use Pmode and word_mode
Ian Lance Taylor
iant@google.com
Mon Mar 5 04:40:00 GMT 2012
"H.J. Lu" <hjl.tools@gmail.com> writes:
>> @@ -11060,8 +11072,8 @@ ix86_expand_split_stack_prologue (void)
>> {
>> rtx rax;
>>
>> - rax = gen_rtx_REG (Pmode, AX_REG);
>> - emit_move_insn (rax, reg10);
>> + rax = gen_rtx_REG (word_mode, AX_REG);
>> + emit_move_insn (rax, gen_rtx_REG (word_mode, R10_REG));
>> use_reg (&call_fusage, rax);
>> }
>>
>> Same here. Please review how AX, R10 and R11 are defined and used.
>> Also, this needs review from split stack author.
>
> I CCed Ian. That is the same issue. We need some scratch registers
> in Pmode to manipulate stack. But we have to save and restore them
> in word_mode, not Pmode.
Changing Pmode to word_mode is fine here, if the x86 maintainers approve
the rest of the patch.
Ian
More information about the Gcc-patches
mailing list