[PATCH, testsuite]: Fix scan-tree-dump-times argument order in gcc.dg/tree-ssa/vrp68.c.

Janis Johnson janis_johnson@mentor.com
Mon Jun 18 20:19:00 GMT 2012


On 06/17/2012 05:03 AM, Richard Guenther wrote:
> On Sun, Jun 17, 2012 at 10:41 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> Hello!
>>
>> The testcase still fails on x86_64-pc-linux-gnu with:
>>
>> FAIL: gcc.dg/tree-ssa/vrp68.c scan-tree-dump-times vrp1 "link_error" 1
>>
>> since there are two calls to link_error.
> 
> Oops.  I wonder how I did not see those failures myself ...
> 
> Richard.

I'm confused about what this test is supposed to do.  It uses
"dg-do link" which means the compile (test for excess errors) will
fail if there is a reference to link_error.  There are two uses of
scan-tree-dump-times for the same string in the same file, so one
of those is guaranteed to fail.  It looks like the scans aren't
needed, and "dg-do link" is the thing that needs the xfail.

Janis



More information about the Gcc-patches mailing list