[patch][PCH] Do not write/read asm_out_file
Richard Sandiford
rdsandiford@googlemail.com
Thu Jun 7 17:59:00 GMT 2012
Steven Bosscher <stevenb.gcc@gmail.com> writes:
> On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> Il 06/06/2012 09:15, Steven Bosscher ha scritto:
>>> + add_asm_printf ("%s\n\t.ascii \"%s\"\n",
>>> + READONLY_DATA_SECTION_ASM_OP, string);
>>> + else
>>
>> Need to escape the string as in mips_output_ascii, of course. :(
>
> Well, I suppose so...
> But I was wondering why mips writes out ident strings as ascii in the
> first place.
>
> The GCC version string is output as .ident with "normal" quoting, but
> a user #ident is printed out as a .ascii. It has been like that since
> the initial revision (r297, more than 20 years ago). See example at
> the bottom of this mail (some test case in the test suite, but I don't
> remember which one).
>
> Shouldn't we just print out .ident for #ident? That would make things
> a lot easier for me, at least :-)
> Richard S.?
Yeah, I think both the ASM_OUTPUT_ASCII and ASM_OUTPUT_IDENT definitions
can go. We only support GAS and ELF these days, and all MIPS configs
need to include elfos.h. Will be a few days before I have chance to
test though.
Richard
More information about the Gcc-patches
mailing list