[patch][libcpp] PR53690 - wrong code for C++11 UCN

Andreas Schwab schwab@linux-m68k.org
Mon Jul 9 07:07:00 GMT 2012


Steven Bosscher <stevenb.gcc@gmail.com> writes:

> In any case, it's valid for C++11. Jason modified charset.c to
> implement the C++11 change and handle the differences between C99 and
> C++11 (*) but I think he overlooked the two lines at the bottom that
> convert a 0 result to 1.

You also get 0 for a partial UCN, which is significant for
forms_identifier_p.

Also this part of the comment needs to be adjusted:

   Otherwise the nonzero value of the UCN, whether valid or invalid,
   is returned.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Gcc-patches mailing list