[gimplefe] Fixing the bug for gimple_assign statement with ternary operands

Diego Novillo dnovillo@google.com
Fri Jul 6 13:57:00 GMT 2012


On 12-07-06 00:38 , Sandeep Soni wrote:

> I am halfway through the patch for building gimple_cond statements. I
> will be able to complete the patch over the weekend. I am also working
> towards a patch that generalizes the assignment statements considering
> all possible types of assignments.

Great!  Thanks.

>
> Tested on x86.
>
> ChangeLog as follows:
>
> 2012-06-06   Sandeep Soni  <soni.sandeepb@gmail.com>
>
> 	* parser.c (gp_parse_expect_rhs_op): Tidy. Returns the tree operand in rhs.	
> 	(gp_parse_assign_stmt): Tidy. Creates the gimple assignment statement .

OK with a couple of minor nits.

> -/* Return the string representation of token TOKEN.  */
>
> -static const char *
> -gl_token_as_text (const gimple_token *token)
> +/* Gets the tree node for the corresponding identifier ID  */

Period at the end of the comment.

> +
> +static tree
> +gimple_symtab_get (tree id)
>   {
> -  switch (token->type)
> +  struct gimple_symtab_entry_def temp;
> +  gimple_symtab_entry_t entry;
> +  void **slot;
> +
> +  gimple_symtab_maybe_init_hash_table();

Space before '('.


Diego.



More information about the Gcc-patches mailing list