[m68k, sparc] Fix atomic_test_and_set

David Miller davem@davemloft.net
Thu Jan 26 22:44:00 GMT 2012


From: Richard Henderson <rth@redhat.com>
Date: Fri, 27 Jan 2012 09:41:10 +1100

> On 01/27/2012 09:34 AM, David Miller wrote:
>> From: Richard Henderson <rth@redhat.com>
>> Date: Fri, 27 Jan 2012 09:29:00 +1100
>> 
>>> Two of the patches have been posted here before; the libstdc++
>>> patch was approved by Benjamin.
>>>
>>> All of the patches tested on sparc64-linux, and sanity checked
>>> on x86_64-linux.  I've cross-compiled for m68k-linux, but I've
>>> only been able to visually sanity check the code in libstdc++.
>>>
>>> Committed.  Hopefully that wraps up the atomic patches...
>> 
>> Why do you need to define TARGET_ATOMIC_TEST_AND_SET_TRUEVAL to 0xff
>> on sparc if you're going to convert the result into a bool in the
>> expander?
> 
> Because the value stored in memory is 0xff, and not a boolean.
> The boolean is only the result type of __atomic_test_and_set.

Gotcha, the changes thus look fine to me.



More information about the Gcc-patches mailing list