[4.7][google] Adding a new option "-fstack-protector-strong". (issue 5461043)
xur@google.com
xur@google.com
Tue Jan 24 21:57:00 GMT 2012
OK for google branches.
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c
File gcc/cfgexpand.c (right):
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1597
gcc/cfgexpand.c:1597: contain an array or are arrays. */
"," before "or", and
two spaces before "*/".
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1709
gcc/cfgexpand.c:1709: create_stack_guard ();
it's better to merge to the earlier if statement. something like:
if (flag_stack_protect == 2
|| (flag_stack_protect == 3 && gen_stack_protect_signal)
|| (flag_stack_protect
&& (cfun->calls_alloca || has_protected_decls)))
create_stack_guard ();
http://codereview.appspot.com/5461043/
More information about the Gcc-patches
mailing list