[RFC][patch] trans-mem: mark transaction begins as returns-twice
Aldy Hernandez
aldyh@redhat.com
Wed Jan 4 16:40:00 GMT 2012
On 01/04/12 09:53, Patrick Marlier wrote:
> On 01/02/2012 01:10 PM, Torvald Riegel wrote:
>> This was motivated by the miscompilation of one of the STAMP
>> applications (Genome), where a stack slot was used as temp storage for a
>> CPU register but not restored when the transaction got aborted and
>> restarted (then, after restart, the program crashed because it used
>> inconsistent data). With the attached patch and in this particular
>> example, the stack slots that are written to in the transaction do not
>> get read during the transaction. (-fno-caller-saves was not a
>> sufficient solution, BTW.)
>
> Are you sure this not due to the missing of tm-logging? We xfail until
> now for the testsuite but this should be addressed. (Note that I tested
> genome months ago and it was working correctly.)
>
> By the way, what's the status of this problem of tm-logging?
I'm chugging along on the TM PR's, but so far the bug reporters are
beating me :). I can move this problem to the top of the list if you
want. If so, what is the PR?
More information about the Gcc-patches
mailing list