[PATCH] Fix PR 51910, -frepo/linker demangling interaction

[Jason Merrill]

On 02/01/2012 01:51 PM, Sandra Loosemore wrote:
> I don't think this is even really a regression.

The testcase works with 4.6 and not with pre-4.7; that makes it a 
regression.

> I haven't actually sat
> down to try to reproduce this, but backing out the previous patch would
> leave the -frepo behavior even more broken on Windows hosts than it is
> now; one of the bugs fixed by the previous patch was that on Windows
> collect2 *always* told ld to demangle names and there was no way for
> users to override this via a command-line option or setting
> COLLECT_NO_DEMANGLE. And, I think the -frepo bug was present on Linux
> hosts too if you explicitly configured your GCC build with
> --with-demangler-in-ld, which is what you need to do if you want ld to
> be able to produce demangled link maps at all.

Yep.

> (BTW, the CodeSourcery IDE adds -Wl,-Map to the link line by default
> because it's easier to always generate a link map than to have to
> explain to users how to get one. Especially in the embedded space, it's
> something many of our users actually do look at.)

Why do you want the link map to be demangled?  It seems more reliable to 
deal with mangled symbols; there's always c++filt if you want to check 
what the symbols demangle to.

Jason