[PATCH][Cilkplus] Fix pragma simd info being lost

Jakub Jelinek jakub@redhat.com
Fri Dec 14 16:59:00 GMT 2012


On Fri, Dec 14, 2012 at 04:59:02AM +0000, Iyer, Balaji V wrote:
> --- tree-vect-loop.c	(revision 194483)
> +++ tree-vect-loop.c	(working copy)
> @@ -234,8 +234,8 @@
>  		  if (flag_enable_cilk && pragma_simd_assert_requested_p
>  		      (loop->pragma_simd_index))
>  		    {
> -		      error ("Loop not vectorized. " 
> -			     "Exiting as requested by Pragma SIMD");
> +		      fatal_error ("Loop not vectorized. " 
> +				   "Exiting as requested by Pragma SIMD");
>  		    }
>  		  return false;
>  		}

Why do you think fatal_error is the right thing here?  Why doesn't normal
error work?  Generally, if one function contains 10 #pragma simd loops that
require vectorization and 5 out of them aren't vectorized, it is nicer for
users to be told about all 5 of them, rather than just the first one.
fatal_error will exit immediately.

	Jakub



More information about the Gcc-patches mailing list