[patch, mips] Fix -mno-shared option (gcc.target/mips/pr35802.c)

Andrew Pinski pinskia@gmail.com
Mon Dec 10 19:45:00 GMT 2012


On Mon, Dec 10, 2012 at 9:23 AM, Steve Ellcey <sellcey@mips.com> wrote:
>
> The test gcc.target/mips/pr35802.c is failing with the message:
>
>         xgcc: error: unrecognized command line option '-mdsp-mno-shared'
>
> Obviously the -mdsp and -mno-shared flags got stuck together without
> a space between them.  This patch fixes the failure.  Ok to checkin?
> It was tested with no regressions.
>
> 2012-12-10  Steve Ellcey  <sellcey@mips.com>
>
>         * config/mips/gnu-user.h (NO_SHARED_SPECS): Add space before option.

I think the space should go before the %{ like most of the other SPECS
macros in that file.
So like:
# define NO_SHARED_SPECS \
  " %{mshared|mno-shared|fpic|fPIC|fpie|fPIE:;:-mno-shared}"

Thanks,
Andrew Pinski

>
>
> diff --git a/gcc/config/mips/gnu-user.h b/gcc/config/mips/gnu-user.h
> index d35ddac..55ca662 100644
> --- a/gcc/config/mips/gnu-user.h
> +++ b/gcc/config/mips/gnu-user.h
> @@ -97,7 +97,7 @@ along with GCC; see the file COPYING3.  If not see
>  #ifdef HAVE_AS_NO_SHARED
>  /* Default to -mno-shared for non-PIC.  */
>  # define NO_SHARED_SPECS \
> -  "%{mshared|mno-shared|fpic|fPIC|fpie|fPIE:;:-mno-shared}"
> +  "%{mshared|mno-shared|fpic|fPIC|fpie|fPIE:;: -mno-shared}"
>  #else
>  # define NO_SHARED_SPECS ""
>  #endif



More information about the Gcc-patches mailing list