Speedups/Cleanups: End of GSOC patch collection

Dodji Seketeli dodji@seketeli.org
Mon Aug 20 09:20:00 GMT 2012


Dimitrios Apostolou <jimis@gmx.net> a écrit:

[...]

> 	* include/libiberty.h (XOBDELETE, XOBGROW, XOBGROWVEC, XOBSHRINK)
> 	(XOBSHRINKVEC, XOBFINISH): New type-safe macros for obstack
> 	operations.
> 	(XOBFINISH): Changed to return (T *) instead of T. All callers
> 	updated.
> 	* libcpp/include/symtab.h (obstack_chunk_alloc)
> 	(obstack_chunk_free): Define, so that obstack_init() can be used.
> 	* libcpp/internal.h (struct cset_converter): Same.
> 	* libcpp/files.c (_cpp_init_files): Changed _obstack_begin() to
> 	obstack_init().
> 	* libcpp/identifiers.c (_cpp_init_hashtable): Same.
> 	* libcpp/symtab.c (ht_create): Same.
> 	* libcpp/init.c (cpp_create_reader): Same.
>

[...]

> +++ libcpp/include/symtab.h	2012-08-18 15:07:01 +0000

[...]

> +#ifndef obstack_chunk_alloc

Please add a comment here, as you did bellow in hunk for
libcpp/internal.h:

    > +#ifndef obstack_chunk_alloc
    > +  /* Needed for calling obstack_init().  */
    > +  #define obstack_chunk_alloc 	(void *(*) (long)) xmalloc
    > +  #define obstack_chunk_free 	(void (*) (void *)) free
    > +#endif

> +  #define obstack_chunk_alloc 	(void *(*) (long)) xmalloc
> +  #define obstack_chunk_free 	(void (*) (void *)) free
> +#endif

[...]

With these changes, the libcpp parts look OK to me if they still
boostrap post c++ conversion.  I am not a maintainer so I a deferring to
Tom and the other maintainers.

Thanks.

-- 
		Dodji



More information about the Gcc-patches mailing list