[patch] timevar TLC

Steven Bosscher stevenb.gcc@gmail.com
Tue Aug 14 20:40:00 GMT 2012


On Tue, Aug 14, 2012 at 9:25 PM, Diego Novillo <dnovillo@google.com> wrote:
>> This 32 is just currently the longest name length of all timevars (for
>> "straight-line strength reduction"), but there are a few more long
>> ones ("PCH preprocessor state restore" ...). I didn't look at the
>> total length of the lines that -ftime-report produces now. It fits on
>> my screen, that's what mattered to me :-)
>
>
> Heh, OK.  I'd like to make it 80 - len(everything else).  Most folks use 80
> col windows.

I seriously doubt that ;-)

Anyway, it's not so simple, this 80-len(everything else). I was
looking for a solution like that but it can't be done: there is no
"everything else". It depends on the configuration -- more
specifically on HAVE_USER_TIME, HAVE_SYS_TIME, and HAVE_WALL_TIME. The
format of these three is:
"%7.2f (%2.0f%%) usr" "%7.2f (%2.0f%%) sys" "%7.2f (%2.0f%%) wall"

So that's 7+2+2+6 + 7+2+2+6 + 7+2+2+7 = 52 (if I got the math right,
if you have all three.

In addition you have the memory stats: "%8u kB (%2.0f%%) ggc". That's
another 8+5+2+6=21.

So you have 80-52-21=7. Take the ":" off and your maximum length for
the timevar print names is 6 characters.

So I'd really like to go with the patch as-is, it's certainly not
making things any worse than they already are for those who work on
good old 80col windows.

Ciao!
Steven



More information about the Gcc-patches mailing list