[Patch,AVR] PR54222: Add fixed point support

Weddington, Eric Eric.Weddington@atmel.com
Fri Aug 10 17:56:00 GMT 2012


> -----Original Message-----
> From: Georg-Johann Lay
> Sent: Friday, August 10, 2012 11:06 AM
> To: Weddington, Eric
> Cc: gcc-patches@gcc.gnu.org; Denis Chertykov
> Subject: Re: [Patch,AVR] PR54222: Add fixed point support
> 
> The first step would be to bisect and find the patch that lead to
> PR53923.  It was not a change in the avr BE, so the question
> goes to the authors of the respective patch.
> 
> Up to now I didn't even try to bisect; that would take years on
> the host that I have available...
> 
> > My only real concern is that this is a major feature addition and
> > the AVR port is currently broken.
> 
> I don't know if it's the avr port or some parts of the middle end
> that don't cooperate with avr.
> 

I would really, really love to see fixed point support added in, especially since I know that Sean has worked on it for quite a while, and you've also done a lot of work in getting the patches in shape to get them committed.

But, if the AVR port is currently broken (by whomever, and whatever patch) and a major feature like this can't be tested to make sure it doesn't break anything else in the AVR backend, then I'm hesitant to approve (even though I really want to approve).

I'll defer to Denis on this one. Or, until the AVR port is fixed and can be tested properly.

Oh, an afterthought: Can this patch work on a snapshot *before* the breakage from PR53923? I see that that bug report was only from a month ago, and doing that might give us some indication that the patch won't break anything else on the AVR port.

Eric Weddington



More information about the Gcc-patches mailing list