[PATCH] Remove unnecessary sparc code attr.

David Miller davem@davemloft.net
Thu Sep 29 21:21:00 GMT 2011


From: Jakub Jelinek <jakub@redhat.com>
Date: Thu, 29 Sep 2011 10:12:58 +0200

> On the other side, I'm surprised you don't need to prefix gcm_name with GCM:
> - when you have more than one mode iterator in a pattern, IMHO you should
> make it clear which mode you are talking about.  Maybe it works, but which
> one it is?  The first mode_iterator declared in the *.md files (and used in
> the pattern), the last one, the first mode_iterator encountered in the
> pattern, the last one?
> So IMHO it should be <GCM:gcm_name> in both cases.
> 
> And there is just one code iterator, can't you use just <code> instead of
> <gcond:code>?

You're right on all counts, thus I committed the following.  Thanks Jakub!

--------------------
More sparc pixel-compare insn pattern cleanups.

	* config/sparc/sparc.md (VIS pixel-compare insn): There is only one
	code iterator used, so just use <code>.  There are two mode iterators
	so explicitly use <GCM:gcm_name>.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@179366 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog             |    6 +++++-
 gcc/config/sparc/sparc.md |    4 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index c831d39..ea5c6d0 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -33,7 +33,7 @@
 	forward declaration.
 	(remove_duplicate_close_phi): Detect and repair creation of
 	duplicate close-phis for a containing loop.
-	
+
 2011-09-27   Andi Kleen <ak@linux.intel.com>
 
 	* gcc.c (get_local_tick). Rename to get_random_number.
@@ -112,6 +112,10 @@
 	* config/sparc/sparc.md (gcond_name): Delete unnecessary code attr.
 	(VIS pixel-compare insn): Just use <gcond:name>.
 
+	* config/sparc/sparc.md (VIS pixel-compare insn): There is only one
+	code iterator used, so just use <code>.  There are two mode iterators
+	so explicitly use <GCM:gcm_name>.
+
 2011-09-29  Iain Sandoe  <iains@gcc.gnu.org>
 
 	* config/darwin9.h (STACK_CHECK_STATIC_BUILTIN): Enable for
diff --git a/gcc/config/sparc/sparc.md b/gcc/config/sparc/sparc.md
index d9bcd31..2def8d1 100644
--- a/gcc/config/sparc/sparc.md
+++ b/gcc/config/sparc/sparc.md
@@ -8151,13 +8151,13 @@
 (define_mode_iterator GCM [V4HI V2SI])
 (define_mode_attr gcm_name [(V4HI "16") (V2SI "32")])
 
-(define_insn "fcmp<gcond:code><gcm_name><P:mode>_vis"
+(define_insn "fcmp<code><GCM:gcm_name><P:mode>_vis"
   [(set (match_operand:P 0 "register_operand" "=r")
   	(unspec:P [(gcond:GCM (match_operand:GCM 1 "register_operand" "e")
 		              (match_operand:GCM 2 "register_operand" "e"))]
 	 UNSPEC_FCMP))]
   "TARGET_VIS"
-  "fcmp<gcond:code><gcm_name>\t%1, %2, %0"
+  "fcmp<code><GCM:gcm_name>\t%1, %2, %0"
   [(set_attr "type" "fpmul")
    (set_attr "fptype" "double")])
 
-- 
1.7.6.401.g6a319



More information about the Gcc-patches mailing list