RFA: Avoiding unprofitable speculation

Richard Guenther richard.guenther@gmail.com
Tue Sep 27 13:51:00 GMT 2011


On Tue, Sep 27, 2011 at 12:30 AM, Jeff Law <law@redhat.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/18/11 15:59, Richard Henderson wrote:
>> On 08/17/2011 12:21 AM, Richard Guenther wrote:
>>> The patch itself looks sensible, though I am surprised ifcvt
>>> doesn't run in cfglayout mode (so you have to use reg notes to
>>> find probabilities ...)
>>
>> It does run in cfglayout mode.
>>
>> Jeff, I believe you're supposed to get the probabilities from some
>> combination of
>>
>> bb->frequency edge->probability EDGE_FREQUENCY(edge)
> OK.  Here's the revised patch.  There's other places in ifcvt.c that
> utilize the notes that I didn't modify.
>
> Bootstrapped & regression tested x86_64-unknown-linux-gnu.  Also
> verified performance data hasn't changed materially.
>
> OK for trunk?

Looks good to me.

Thanks,
Richard.

> Thanks,
> jeff
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJOgPzuAAoJEBRtltQi2kC7uQkH+wTyLl3MwKkqC11ozyOAVSQ9
> CrlwLAuN7JV7kZcguKZ9GpXYHePZHZHCISXaVv3LQQBXnE7PehJOWsd1D5BQRv2/
> eqVHIAOYg0LamY2cRiWW8pKMiMjs7vb9q0fiehQGg0zxAJMc9crBjwLPGFjZAksw
> UNzzon/NKfSMYsz9X/olDfk8DPa1DmAjBnNOcHzKLGdx7KDa6Npo20k3D/PwDbIe
> y1Ff9pZBXJP6tNU+0cn9lyyt+w6ghFQRkpKJoJ6iSOxKQ6v23+03o4sT5GHv3Gvy
> 07R6NJU9vqt7a9GvxcyJ9BsOlCCJ/pA/4lProHrdcAZrOYWZAA4uoJeDBPOEq+g=
> =a5LI
> -----END PGP SIGNATURE-----
>



More information about the Gcc-patches mailing list