[PATCH 3/7] Emit macro expansion related diagnostics

Jason Merrill jason@redhat.com
Mon Sep 26 22:30:00 GMT 2011


On 09/26/2011 04:21 PM, Dodji Seketeli wrote:
> Jason Merrill<jason@redhat.com>  writes:
>
>> On 09/21/2011 02:32 PM, Dodji Seketeli wrote:
>>> FWIW, I'd like the LRK_MACRO_PARM_REPLACEMENT name (or its
>>> replacement.  ha ha) to hint at the fact that it really has to do with
>>> a token that is an /argument/ for a function-like macro.
>>
>> I disagree; arguments are the situation when the two locations differ,
>> but this one (yI) is always the source location in the macro
>> definition
>
> I think an interesting question to ask here is "the source location of
> what exactly?".

It's the source location of what we're currently looking at, which is a 
virtual token in the macro expansion.

My point is that yI is always a source location, whereas xI may or may 
not be.

> Would LRK_MACRO_DEFINITION_LOCATION be better then?  :-)

Yes.  :)

Jason



More information about the Gcc-patches mailing list