devirtualize final virtual function calls
Jason Merrill
jason@redhat.com
Tue Sep 20 19:35:00 GMT 2011
On 09/20/2011 12:43 PM, Roberto Agostino Vitillo wrote:
> - if (DECL_VINDEX (fn)&& ! (flags& LOOKUP_NONVIRTUAL)
> - && resolves_to_fixed_type_p (instance, 0))
> + if (DECL_VINDEX (fn)&& ((! (flags& LOOKUP_NONVIRTUAL)
> + && resolves_to_fixed_type_p (instance, 0))
> + || DECL_FINAL_P (fn) || CLASSTYPE_FINAL (basetype)))
> flags |= LOOKUP_NONVIRTUAL;
I think we don't need the extra parentheses on the flags test here; if
LOOKUP_NONVIRTUAL is already set, we can stop right there rather than
look for reasons to set it.
I'll go ahead and change that and check in the patch.
This patch is small enough not to need a copyright assignment, but it
would be good to get one on file now so that we don't need to wait on
that for future patches. You can get more information about copyright
assignment from copyright-clerk@fsf.org
Thanks,
Jason
More information about the Gcc-patches
mailing list