[Trunk/GCC 4.6] Re: [google] Omit date from Fortran .mod files for reproducible builds

[Janne Blomqvist]

On Fri, Sep 16, 2011 at 21:06, Diego Novillo <dnovillo@google.com> wrote:
> On Fri, Jan 28, 2011 at 13:00, Diego Novillo <dnovillo@google.com> wrote:
>> On Fri, Jan 28, 2011 at 06:19, Tobias Burnus <burnus@net-b.de> wrote:
>>> We (Janne and I) think this patch can also be applied to the GCC 4.6 trunk;
>>> as the date is never read there is also no .mod ABI issue.
>>>
>>> I assume that there are no copyright issues.
>>
>> There aren't.  Google has signed a blanket copyright assignment with
>> the FSF.  Any patch coming from a google.com address is covered.
>>
>> I'll mark this patch for trunk.  Thanks.
>
> Tobias, I'm planning to apply this (old) patch to trunk.  Still OK?

Yes, ok.

>
> I've re-bootstrapped on x86_64.  No new failures.
>
>
> Thanks.  Diego.
>
> 2011-09-16  Simon Baldwin  <simonb@google.com>
>
>       * module.c (gfc_dump_module): Omit timestamp from output.
>
> diff --git a/gcc/fortran/module.c b/gcc/fortran/module.c
> index 4250a17..b29ba4b 100644
> --- a/gcc/fortran/module.c
> +++ b/gcc/fortran/module.c
> @@ -5178,8 +5178,7 @@ void
>  gfc_dump_module (const char *name, int dump_flag)
>  {
>   int n;
> -  char *filename, *filename_tmp, *p;
> -  time_t now;
> +  char *filename, *filename_tmp;
>   fpos_t md5_pos;
>   unsigned char md5_new[16], md5_old[16];
>
> @@ -5221,13 +5220,8 @@ gfc_dump_module (const char *name, int dump_flag)
>                     filename_tmp, xstrerror (errno));
>
>   /* Write the header, including space reserved for the MD5 sum.  */
> -  now = time (NULL);
> -  p = ctime (&now);
> -
> -  *strchr (p, '\n') = '\0';
> -
> -  fprintf (module_fp, "GFORTRAN module version '%s' created from %s on %s\n"
> -          "MD5:", MOD_VERSION, gfc_source_file, p);
> +  fprintf (module_fp, "GFORTRAN module version '%s' created from %s\n"
> +          "MD5:", MOD_VERSION, gfc_source_file);
>   fgetpos (module_fp, &md5_pos);
>   fputs ("00000000000000000000000000000000 -- "
>        "If you edit this, you'll get what you deserve.\n\n", module_fp);
>



-- 
Janne Blomqvist