[Patch] Finish function using absolute value not #define value
Iyer, Balaji V
balaji.v.iyer@intel.com
Sun Sep 11 21:23:00 GMT 2011
Hi H. J,
Here is the fixed patch, with corrected email subject and changelog:
Thanks,
Balaji V. Iyer.
cp/ChangeLog
2011-09-09 Balaji V. Iyer <balaji.v.iyer@intel.com>
* decl2.c (finish_objects): Replaced parameter '0' inside
finish_function with SF_PRE_PARSED.
(finish_static_storage_duration_function): Likewise.
* decl.c (end_cleanup_fn): Likewise.
* method.c (synthesize_method): Likewise.
* optimize.c (maybe_clone_body): Likewise.
* pt.c (instantiate_decl): Likewise.
* parser.c (cp_parser_function_definition_after_declarator): Replaced '0', '1',
and '2' in finish_function parameters with SF_DEFAULT, SF_PRE_PARSED and
SF_INCLASS_INLINE, respectively.
(cp_parser_lambda_body): Replaced parameter '2' inside
finish_function with SF_INCLASS_INLINE.
* semantics.c (maybe_add_lambda_conv_op): Likewise.
Here is the objcp/ChangeLog
2011-09-09 Balaji V. Iyer <balaji.v.iyer@intel.com>
* objcp-decl.c (objcp_finish_function): Replaced parameter '0' inside
finish_function with SF_PRE_PARSED
-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com]
Sent: Friday, September 09, 2011 11:14 AM
To: Iyer, Balaji V
Cc: Tobias Burnus; gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Finish function using absolute value not #define value
On Fri, Sep 9, 2011 at 7:48 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Hello Everyone,
> Here are the fixes to the patches as mentioned by H. J. . I am not attaching the patch, just cut and pasting it.
Cut/paste may not work if other people have to apply the patch for you.
> Thanks,
>
> Balaji V. Iyer.
>
> Here is the cp/ChangeLog
>
> 2011-09-09 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> * decl2.c (finish_objects): Replaced finish_function (0) with
> finish_function (SF_PRE_PARSED).
> (finish_static_storage_duration_function): Likewise.
> * decl.c (end_cleanup_fn): Likewise.
> * method.c (synthesize_method): Likewise.
> * optimize.c (maybe_clone_body): Likewise.
> * pt.c (instantiate_decl): Likewise.
> * parser.c (cp_parser_function_definition_after_declarator):
> Replaced
> finish_function ((ctor_initializer_p ? 1 : 0) | (inline_p ? 2 :
> 0))
> with finish_function ((ctor_initializer_p ? SF_PRE_PARSED :
> SF_DEFAULT)
> | (inline_p ? SF_INCLASS_INLINE : SF_DEFAULT)).
> * parser.c (cp_parser_lambda_body): Replaced finish_function
> (2) with
> finish_function (SF_INCLASS_INLINE).
> * semantics.c (maybe_add_lambda_conv_op): Likewise.
>
> Here is the objcp/ChangeLog
>
> 2011-09-09 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> * objcp-decl.c (objcp_finish_function): Replaced
> finish_function (0)
> with finish_function (SF_DEFAULT).
>
Your ChangeLog can just say "Use SF_DEFAULT, SF_PRE_PARSED and SF_INCLASS_INLINE."
--
H.J.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: finish_function_patch.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20110911/0b3ca948/attachment.txt>
More information about the Gcc-patches
mailing list